Skip to content

Commit

Permalink
Nits by Jake
Browse files Browse the repository at this point in the history
  • Loading branch information
surma committed Jul 20, 2018
1 parent 13ac3ed commit df7e112
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions src/codecs/browser-webp/decoder.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { canDecodeImage, createImageBitmapPolyfill } from '../../lib/util';

export const name = 'Browser WebP Decoder';
export const supportedMimeTypes = ['image/webp'];
export async function decode(file: File): Promise<ImageBitmap> {
return createImageBitmapPolyfill(file);
export async function decode(blob: Blob): Promise<ImageBitmap> {
return createImageBitmapPolyfill(blob);
}

// tslint:disable-next-line:max-line-length It’s a data URL. Whatcha gonna do?
Expand All @@ -13,6 +12,7 @@ export function isSupported(): Promise<boolean> {
return canDecodeImage(webpFile);
}

const supportedMimeTypes = ['image/webp'];
export function canHandleMimeType(mimeType: string): boolean {
return supportedMimeTypes.includes(mimeType);
}
6 changes: 3 additions & 3 deletions src/codecs/webp/decoder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@ import { blobToArrayBuffer, imageDataToBitmap } from '../../lib/util';
import DecoderWorker from './Decoder.worker';

export const name = 'WASM WebP Decoder';
export const supportedMimeTypes = ['image/webp'];
export async function decode(file: File): Promise<ImageBitmap> {
export async function decode(blob: Blob): Promise<ImageBitmap> {
const decoder = await new DecoderWorker();
const imageData = await decoder.decode(await blobToArrayBuffer(file));
const imageData = await decoder.decode(await blobToArrayBuffer(blob));
return imageDataToBitmap(imageData);
}

export async function isSupported(): Promise<boolean> {
return true;
}

const supportedMimeTypes = ['image/webp'];
export function canHandleMimeType(mimeType: string): boolean {
return supportedMimeTypes.includes(mimeType);
}
2 changes: 1 addition & 1 deletion src/lib/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ const magicNumberToMimeType = new Map<RegExp, string>([
[/^RIFF....WEBPVP8 /, 'image/webp'],
]);

export async function sniffMimeType(blob: Blob): Promise<string | ''> {
export async function sniffMimeType(blob: Blob): Promise<string> {
const firstChunk = await blobToArrayBuffer(blob.slice(0, 16));
const firstChunkString =
Array.from(new Uint8Array(firstChunk))
Expand Down

0 comments on commit df7e112

Please sign in to comment.