Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-byte characters sanitization in short name field #984

Merged
merged 2 commits into from
May 15, 2023

Conversation

thelovekesh
Copy link
Collaborator

Fixes: #971

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (456f039) 19.65% compared to head (82e77da) 19.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #984   +/-   ##
==========================================
  Coverage      19.65%   19.65%           
  Complexity       347      347           
==========================================
  Files             57       57           
  Lines           2325     2325           
==========================================
  Hits             457      457           
  Misses          1868     1868           
Flag Coverage Δ
php 19.65% <100.00%> (ø)
unit 19.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wp-includes/class-wp-web-app-manifest.php 66.52% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thelovekesh thelovekesh requested a review from westonruter May 14, 2023 13:30
Copy link
Collaborator

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@westonruter westonruter merged commit b194c64 into develop May 15, 2023
@westonruter westonruter deleted the fix/multibyte-escaping branch May 15, 2023 16:03
@westonruter westonruter added this to the 0.8 milestone May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Short Name field sanitization does not account for multi-byte characters
3 participants