Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate redundant Short Name field row #954

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

westonruter
Copy link
Collaborator

This addresses an oversight in #691, in which a duplicate Short Name table was being generated inside of a Short Name table row. The table's inner row was being moved up below the Site Name leaving the outer Short Name row in place. This resulted in Short Name table heading cell appearing twice, but in the second instance there was no corresponding field.

Fixes #952

@westonruter westonruter added this to the 0.8 milestone Mar 24, 2023
@westonruter westonruter added the web-app-manifest Web App Manifests label Mar 24, 2023
@westonruter westonruter merged commit bad3b9d into develop Mar 24, 2023
@westonruter westonruter deleted the fix/short-name-field branch March 24, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web-app-manifest Web App Manifests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate short name setting
1 participant