Add service worker integration for AMP (temporarily) #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
changed the title
amedina
approved these changes
Oct 4, 2018
felixarntz
approved these changes
Oct 4, 2018
There was a problem hiding this comment.
This looks good to me. I think it would be nice if we used a Service_Worker_Integration for parts of it, but it's not a necessity. Especially since this is going to move to the AMP plugin at some point, I'm +1 on the current state. We could always enhance later.
amp/class-amp-service-worker.php
Outdated
| */ | ||
| public function add_amp_runtime_caching( $service_workers ) { | ||
| if ( ! ( $service_workers instanceof WP_Service_Worker_Scripts ) ) { | ||
| _doing_it_wrong( __METHOD__, esc_html__( 'Expected argument to be WP_Service_Workers.', 'amp' ), '1.0' ); |
There was a problem hiding this comment.
Copy-paste issue, this should be WP_Service_Worker_Scripts :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is porting ampproject/amp-wp#1261 over to the PWA plugin to make it easier to work with while the PWA plugin's API is in flux. And it will allow us to more easily test the API with the AMP plugin as it goes to 1.0 shortly.
Once the API is stabilized, then the AMP functionality would move over to the AMP plugin.