Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate integrations #713

Merged
merged 9 commits into from
Mar 4, 2022
Merged

Deprecate integrations #713

merged 9 commits into from
Mar 4, 2022

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Feb 28, 2022

Fixes #403

Tasks Done:

  • Add function to show user a warning about integrations deprecation.
  • Add @deprecated tags in functions and classes.

Screenshot:
image

@thelovekesh
Copy link
Collaborator Author

@westonruter I have added @deprecated tags to function/classes and a function to show warnings in the user console as you instructed. Please let me know if this PR needs more improvements.

integrations/interface-wp-service-worker-integration.php Outdated Show resolved Hide resolved
pwa.php Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2022

Codecov Report

Merging #713 (56b3d8d) into develop (749a985) will decrease coverage by 1.54%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #713      +/-   ##
=============================================
- Coverage      19.96%   18.41%   -1.55%     
- Complexity       326      334       +8     
=============================================
  Files             56       57       +1     
  Lines           2094     2270     +176     
=============================================
  Hits             418      418              
- Misses          1676     1852     +176     
Flag Coverage Δ
php 18.41% <0.00%> (-1.55%) ⬇️
unit 18.41% <0.00%> (-1.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ass-wp-service-worker-admin-assets-integration.php 0.00% <0.00%> (ø)
...tions/class-wp-service-worker-base-integration.php 0.00% <ø> (ø)
...p-service-worker-custom-background-integration.php 0.00% <0.00%> (ø)
...ss-wp-service-worker-custom-header-integration.php 0.00% <0.00%> (ø)
...lass-wp-service-worker-custom-logo-integration.php 0.00% <0.00%> (ø)
...ions/class-wp-service-worker-fonts-integration.php 0.00% <0.00%> (ø)
...ns/class-wp-service-worker-scripts-integration.php 0.00% <0.00%> (ø)
.../class-wp-service-worker-site-icon-integration.php 0.00% <0.00%> (ø)
...ons/class-wp-service-worker-styles-integration.php 0.00% <0.00%> (ø)
integrations/functions.php 0.00% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 749a985...56b3d8d. Read the comment docs.

@westonruter westonruter merged commit f22026f into develop Mar 4, 2022
@westonruter westonruter deleted the add/deprecate-integrations branch March 4, 2022 21:38
@westonruter westonruter added this to the 0.7 milestone Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate integrations
3 participants