-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apple_touch_startup_images filter #595
Add apple_touch_startup_images filter #595
Conversation
3cf7846
to
a916a32
Compare
The test failure for "Unit test: PHP 8.0, WP trunk" appears unrelated to this change. |
Yeah. That's something I need to fix along the lines of what @pierlon has done in ampproject/amp-wp#6525. |
This adds an apple_touch_startup_images filter for plugins/themes to adjust the rel="apple-touch-startup-image" link tags outputted. This allows more images to be added, with an applicable media attribute for each image. Fixes GoogleChromeLabs#586.
a916a32
to
5040f39
Compare
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
Codecov Report
@@ Coverage Diff @@
## develop #595 +/- ##
=============================================
+ Coverage 17.51% 18.05% +0.54%
- Complexity 300 305 +5
=============================================
Files 55 55
Lines 1776 1789 +13
=============================================
+ Hits 311 323 +12
- Misses 1465 1466 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This adds an
apple_touch_startup_images
filter for plugins/themes to adjust therel="apple-touch-startup-image"
link tags outputted. This allows more images to be added, with an applicablemedia
attribute for each image.Fixes #586.