Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apple_touch_startup_images filter #595

Conversation

jefferyto
Copy link
Contributor

@jefferyto jefferyto commented Aug 11, 2021

This adds an apple_touch_startup_images filter for plugins/themes to adjust the rel="apple-touch-startup-image" link tags outputted. This allows more images to be added, with an applicable media attribute for each image.

Fixes #586.

@google-cla google-cla bot added the cla: yes label Aug 11, 2021
@jefferyto jefferyto force-pushed the apple-touch-startup-image-filter branch from 3cf7846 to a916a32 Compare August 13, 2021 07:47
@jefferyto
Copy link
Contributor Author

The test failure for "Unit test: PHP 8.0, WP trunk" appears unrelated to this change.

@westonruter
Copy link
Collaborator

The test failure for "Unit test: PHP 8.0, WP trunk" appears unrelated to this change.

Yeah. That's something I need to fix along the lines of what @pierlon has done in ampproject/amp-wp#6525.

wp-includes/class-wp-web-app-manifest.php Outdated Show resolved Hide resolved
wp-includes/class-wp-web-app-manifest.php Outdated Show resolved Hide resolved
wp-includes/class-wp-web-app-manifest.php Outdated Show resolved Hide resolved
wp-includes/class-wp-web-app-manifest.php Show resolved Hide resolved
wp-includes/class-wp-web-app-manifest.php Outdated Show resolved Hide resolved
This adds an apple_touch_startup_images filter for plugins/themes to
adjust the rel="apple-touch-startup-image" link tags outputted. This
allows more images to be added, with an applicable media attribute for
each image.

Fixes GoogleChromeLabs#586.
@jefferyto jefferyto force-pushed the apple-touch-startup-image-filter branch from a916a32 to 5040f39 Compare August 17, 2021 08:39
@jefferyto jefferyto changed the title Add apple_touch_startup_image filter Add apple_touch_startup_images filter Aug 17, 2021
@jefferyto jefferyto requested a review from westonruter August 17, 2021 08:43
@google-cla
Copy link

google-cla bot commented Aug 17, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Aug 17, 2021
@westonruter
Copy link
Collaborator

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 17, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #595 (50e7daf) into develop (4aa2b8a) will increase coverage by 0.54%.
The diff coverage is 92.30%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #595      +/-   ##
=============================================
+ Coverage      17.51%   18.05%   +0.54%     
- Complexity       300      305       +5     
=============================================
  Files             55       55              
  Lines           1776     1789      +13     
=============================================
+ Hits             311      323      +12     
- Misses          1465     1466       +1     
Flag Coverage Δ
php 18.05% <92.30%> (+0.54%) ⬆️
unit 18.05% <92.30%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wp-includes/class-wp-web-app-manifest.php 58.73% <92.30%> (+3.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa2b8a...50e7daf. Read the comment docs.

@westonruter westonruter merged commit 69dc3c2 into GoogleChromeLabs:develop Aug 17, 2021
@westonruter westonruter added this to the 0.7 milestone Aug 17, 2021
@jefferyto jefferyto deleted the apple-touch-startup-image-filter branch August 17, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make apple-touch-startup-image link tags filterable
3 participants