-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output link/meta tags depending on web app manifest display value #581
Output link/meta tags depending on web app manifest display value #581
Conversation
This changes when the (apple-)mobile-web-app-capable meta tags (and apple-touch-startup-image link tag) are printed to match the display mode set in the web app manifest. This also removes the apple-touch-fullscreen meta tag, as this tag has the same effect as the apple-mobile-web-app-capable meta tag but is not included in any Safari documentation.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Yes, I can confirm that at https://stackoverflow.com/a/10040966/93579 |
Codecov Report
@@ Coverage Diff @@
## develop #581 +/- ##
=============================================
+ Coverage 17.28% 17.51% +0.22%
- Complexity 296 300 +4
=============================================
Files 55 55
Lines 1770 1776 +6
=============================================
+ Hits 306 311 +5
- Misses 1464 1465 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This changes when the (
apple-
)mobile-web-app-capable
meta tags (andapple-touch-startup-image
link tag) are printed to match the display mode set in the web app manifest.This also removes the
apple-touch-fullscreen
meta tag, as this tag has the same effect as theapple-mobile-web-app-capable
meta tag but is not included in any Safari documentation.