Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output link/meta tags depending on web app manifest display value #581

Merged

Conversation

jefferyto
Copy link
Contributor

This changes when the (apple-)mobile-web-app-capable meta tags (and apple-touch-startup-image link tag) are printed to match the display mode set in the web app manifest.

This also removes the apple-touch-fullscreen meta tag, as this tag has the same effect as the apple-mobile-web-app-capable meta tag but is not included in any Safari documentation.

This changes when the (apple-)mobile-web-app-capable meta tags (and
apple-touch-startup-image link tag) are printed to match the display
mode set in the web app manifest.

This also removes the apple-touch-fullscreen meta tag, as this tag has
the same effect as the apple-mobile-web-app-capable meta tag but is not
included in any Safari documentation.
@google-cla
Copy link

google-cla bot commented Jul 27, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jul 27, 2021
@jefferyto
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 27, 2021
@westonruter
Copy link
Collaborator

This also removes the apple-touch-fullscreen meta tag, as this tag has the same effect as the apple-mobile-web-app-capable meta tag but is not included in any Safari documentation.

Yes, I can confirm that at https://stackoverflow.com/a/10040966/93579

@codecov-commenter
Copy link

Codecov Report

Merging #581 (906c820) into develop (714d850) will increase coverage by 0.22%.
The diff coverage is 88.88%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #581      +/-   ##
=============================================
+ Coverage      17.28%   17.51%   +0.22%     
- Complexity       296      300       +4     
=============================================
  Files             55       55              
  Lines           1770     1776       +6     
=============================================
+ Hits             306      311       +5     
- Misses          1464     1465       +1     
Flag Coverage Δ
php 17.51% <88.88%> (+0.22%) ⬆️
unit 17.51% <88.88%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wp-includes/class-wp-web-app-manifest.php 54.86% <88.88%> (+1.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 714d850...906c820. Read the comment docs.

@westonruter westonruter added this to the 0.7 milestone Jul 27, 2021
Copy link
Collaborator

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@westonruter westonruter merged commit 4aa2b8a into GoogleChromeLabs:develop Jul 27, 2021
@jefferyto jefferyto deleted the link-meta-manifest-display branch July 27, 2021 21:54
@pooja-muchandikar
Copy link

QA Passed ✅

On registering new plugin with following code was able to print meta tags based on the display value set in the code.

Screenshot 2022-04-20 at 4 48 59 PM


Screenshot 2022-04-20 at 4 46 40 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants