Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize workbox-window for service worker registration #578

Merged
merged 9 commits into from
Aug 24, 2021

Conversation

westonruter
Copy link
Collaborator

@westonruter westonruter commented Jul 26, 2021

@westonruter westonruter added this to the 0.7 milestone Jul 26, 2021
@google-cla google-cla bot added the cla: yes label Jul 26, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #578 (56f1611) into develop (714d850) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #578      +/-   ##
=============================================
- Coverage      17.28%   17.25%   -0.03%     
  Complexity       296      296              
=============================================
  Files             55       56       +1     
  Lines           1770     1773       +3     
=============================================
  Hits             306      306              
- Misses          1464     1467       +3     
Flag Coverage Δ
php 17.25% <0.00%> (-0.03%) ⬇️
unit 17.25% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wp-includes/default-filters.php 0.00% <ø> (ø)
wp-includes/deprecated.php 0.00% <0.00%> (ø)
wp-includes/service-workers.php 22.00% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 714d850...56f1611. Read the comment docs.

@westonruter westonruter changed the title Utilize workbox-window for service worker registeration Utilize workbox-window for service worker registration Aug 23, 2021
@westonruter westonruter force-pushed the update/skip-waiting-message branch from 75d26f6 to 495d806 Compare August 23, 2021 05:03
@westonruter westonruter requested a review from amedina August 23, 2021 05:46
Copy link
Collaborator

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@westonruter westonruter merged commit d7e2dea into develop Aug 24, 2021
@westonruter westonruter deleted the update/skip-waiting-message branch August 24, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants