-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize workbox-window for service worker registration #578
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #578 +/- ##
=============================================
- Coverage 17.28% 17.25% -0.03%
Complexity 296 296
=============================================
Files 55 56 +1
Lines 1770 1773 +3
=============================================
Hits 306 306
- Misses 1464 1467 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
75d26f6
to
495d806
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
wp.serviceWorkerWindow
at thedocument
'sDOMContentLoaded
event.wp_service_worker_skip_waiting
is filteredfalse
in PHP, service worker installation waiting can be skipped viawp.serviceWorkerWindow.messageSkipWaiting()
. See Workbox docs.wp_disable_script_concatenation()
since admin service worker is not caching admin assets sinceWP_Service_Worker_Admin_Assets_Integration
is not enabled by default (and it is deprecated per Deprecate integrations #403). As part of this thewordpress_sw_installed
cookie is no longer set when the admin SW is installed.module
script instead oftext/javascript
for SW installation on frontend. This incidentally prevents JS errors IE11 which doesn't understand JS modules. Fixes Backward Compatibility for IE11 #227.