Improve PHPStan config #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #563 +/- ##
==========================================
Coverage 17.28% 17.28%
Complexity 296 296
==========================================
Files 55 55
Lines 1770 1770
==========================================
Hits 306 306
Misses 1464 1464
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@westonruter CI is not configured to trigger static analysis on PHPStan configuration file change! |
szepeviktor
reviewed
Jul 13, 2021
| @@ -5,28 +5,17 @@ parameters: | |||
| level: 5 | |||
| inferPrivatePropertyTypeFromConstructor: true | |||
| paths: | |||
| - %currentWorkingDirectory%/pwa.php | |||
| - %currentWorkingDirectory%/wp-admin | |||
| - %currentWorkingDirectory%/wp-includes | |||
| - %currentWorkingDirectory%/bundled-theme-support | |||
| - %currentWorkingDirectory%/integrations | |||
| bootstrapFiles: | |||
| - %currentWorkingDirectory%/tests/static-analysis-stubs/wordpress-defines.stub | |||
There was a problem hiding this comment.
- %currentWorkingDirectory%/vendor/php-stubs/wordpress-stubs/wordpress-stubs.php is necessary if you don't use my package
There was a problem hiding this comment.
@westonruter Now we are here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving config based on #562 props @szepeviktor.
Amends #560 for #243