Use wp_robots() to prevent indexing the error template on WP≥5.7 #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixarntz
approved these changes
Feb 1, 2021
| @@ -17,7 +17,12 @@ | |||
| add_action( 'wp_ajax_nopriv_wp_service_worker', 'wp_ajax_wp_service_worker' ); | |||
| add_action( 'parse_query', 'wp_unauthenticate_error_template_requests' ); | |||
|
|
|||
| add_action( 'wp_head', 'wp_add_error_template_no_robots' ); | |||
| add_action( 'error_head', 'wp_add_error_template_no_robots' ); | |||
| if ( version_compare( strtok( get_bloginfo( 'version' ), '-' ), '5.7', '>=' ) ) { | |||
There was a problem hiding this comment.
Alternatively we could check for whether the wp_robots function exists to avoid the need for specific version lookup - but I guess the downside of that would be that someone else theoretically could declare a function of that name before. Just a thought, nothing blocking.
|
QA Passed ✅ With WP 5.7 and PWA 0.6 version indexing was not part of error template With WP 5.9.3 and PWA v0.7.0-alpha-52d5096-20220419T054300Z |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a
wp_no_robots()deprecation warning from being raised in WP 5.7-alpha which was introduced in WordPress/wordpress-develop#702.