Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve manifest as application/manifest+json #349

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Serve manifest as application/manifest+json #349

merged 1 commit into from
Nov 25, 2020

Conversation

vdwijngaert
Copy link
Contributor

Fixes #306

@google-cla
Copy link

google-cla bot commented Nov 25, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@vdwijngaert
Copy link
Contributor Author

@googlebot I signed it!

@westonruter westonruter added this to the 0.6 milestone Nov 25, 2020
@westonruter westonruter merged commit 4459e3a into GoogleChromeLabs:develop Nov 25, 2020
westonruter added a commit that referenced this pull request Dec 6, 2020
…/default-network-first-caching-strategy-and-args

* 'develop' of github.com:GoogleChromeLabs/pwa-wp: (28 commits)
  Revert "Bump workbox-cli from 5.1.4 to 6.0.2"
  Bump eslint from 7.14.0 to 7.15.0
  Bump workbox-cli from 5.1.4 to 6.0.2
  Bump requires at least to 5.5 and tested up to 5.6
  Replace Travis badge with GHA badge in readme.md
  Run composer update again
  Add PHP 8 to require, fix WP_TESTS_DIR
  Run composer update
  Update PHP 8 composer.json patch
  Add pre-commit script to composer.json
  Add config to composer.json
  Update test matrix
  Fix linting errors for package.json
  Fix test_register_manifest_rest_route after #349
  Account for s/new_whitelist_options/new_allowed_options/
  Add name for default testsuite
  Run composer update
  Install phpunit as dependency
  Incorporate GitHub actions from AMP plugin
  Remove .travis.yml
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web App Manifest should to be served as application/manifest+json
2 participants