Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid constructing asset versions with HTML entities in context of SW #325

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Avoid constructing asset versions with HTML entities in context of SW #325

merged 1 commit into from
Aug 28, 2020

Conversation

westonruter
Copy link
Collaborator

Follow up on #317.

I realized that in the context of the service worker, the & here should be changed to just & since the resulting URL will not be output to HTML for the browser to decode & back to &.

@westonruter westonruter added this to the 0.6 milestone Aug 28, 2020
@westonruter westonruter mentioned this pull request Aug 28, 2020
Merged
ethitter
ethitter approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@ethitter ethitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Good catch!

@westonruter westonruter merged commit e0d59fd into develop Aug 28, 2020
@westonruter westonruter deleted the add/decoded-ampersands branch August 28, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethitter ethitter ethitter approved these changes

Assignees
No one assigned
Labels
changelogged service-workers
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@westonruter @ethitter