Prevent attempting to precache empty URLs which causes SW install failure #271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #270.
At the moment when attempting to precache an empty URL such as via:
The result is the service worker failing to install at all.
For this reason, this PR emits a
_doing_it_wrong
if the$url
is empty or cannot be parsed. This allows the service worker to still be installed, while the incorrect usage will appear in the error log.Aside: It may be better to also emit the incorrect usage via
console.warn()
so that the issue is more easily seen.