Return bool as WP_Scripts::do_item does #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
reviewed
Feb 10, 2020
swissspidy
reviewed
Feb 10, 2020
as per Pascal asked
|
The build is failing at no fault of the PR. Once #244 is merged, please rebase to re-trigger a build. |
|
I'm not sure why this is still failing. Please pull in the latest changes from |
|
Okay! |
* 'master' of github.com:GoogleChromeLabs/pwa-wp: Remove unneeded build dir Invoke lint and test directly in Travis without wp-dev-lib Fix test_schedule_cron Upgrade Workbox to v5.1.1 Bump acorn from 6.2.0 to 6.4.1
westonruter
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.wordpress.org/reference/classes/wp_scripts/do_item/
Discovered by @phpstan on Level 4