Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix Workbox 'Plugin' classes with the module name after renamed in v5 #220

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Prefix Workbox 'Plugin' classes with the module name after renamed in v5 #220

merged 1 commit into from
Aug 23, 2019

Conversation

westonruter
Copy link
Collaborator

I noticed an error after upgrading to Workbox v5.0.0-beta.0 (#218):

Screen Shot 2019-08-22 at 17 16 14

The issue is that {x}.Plugin was renamed to {x}.{X}Plugin in GoogleChrome/workbox#2072.

So this PR changes the generated JS as follows:

- new wp.serviceWorker[ "expiration" ].Plugin( { /* ... */ } )
+ new wp.serviceWorker[ "expiration" ][ "ExpirationPlugin" ]( { /* ... */ } )

@westonruter westonruter added this to the 0.4 milestone Aug 23, 2019
amedina
amedina approved these changes Aug 23, 2019
View reviewed changes
Copy link
Collaborator

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mándalo!

@westonruter westonruter merged commit cd2b132 into master Aug 23, 2019
@westonruter westonruter deleted the fix/workbox-5-plugin-references branch August 23, 2019 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amedina amedina amedina approved these changes

Assignees
No one assigned
Labels
service-workers
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@westonruter @amedina