Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inefficient rewrite flushing #1096

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

westonruter
Copy link
Collaborator

Fixes #1075

@westonruter westonruter added this to the 0.8 milestone Jan 19, 2024
@westonruter
Copy link
Collaborator Author

Build for testing: pwa.zip

@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (e034397) 29.34% compared to head (eadf98d) 29.45%.

Files Patch % Lines
wp-includes/class-wp.php 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1096      +/-   ##
=============================================
+ Coverage      29.34%   29.45%   +0.10%     
  Complexity       334      334              
=============================================
  Files             57       57              
  Lines           1690     1684       -6     
=============================================
  Hits             496      496              
+ Misses          1194     1188       -6     
Flag Coverage Δ
php 29.45% <0.00%> (+0.10%) ⬆️
unit 29.45% <0.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonruter westonruter merged commit 0bc41e5 into develop Jan 24, 2024
18 checks passed
@westonruter westonruter deleted the fix/inefficient-rewrite-flushing branch January 24, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suboptimal rewrite handling causes plugin conflicts
3 participants