Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin_title filter called without ensuring current_screen is set #206

Closed
rrennick opened this issue Aug 1, 2019 · 2 comments · Fixed by #207
Closed

admin_title filter called without ensuring current_screen is set #206

rrennick opened this issue Aug 1, 2019 · 2 comments · Fixed by #207
Milestone
0.3

Comments

@rrennick
Copy link

rrennick commented Aug 1, 2019

In /wp-admin/error.php, the admin_title filter is used without ensuring that the current_screen is set: https://github.com/xwp/pwa-wp/blob/7cf111f43dff028d6331009eabdc25848e6cd44f/wp-admin/error.php#L45

admin-header.php does this with https://github.com/WordPress/WordPress/blob/master/wp-admin/admin-header.php#L29:L32

before using the filter in https://github.com/WordPress/WordPress/blob/master/wp-admin/admin-header.php#L68.

This is causing the fatal error reported in woocommerce/woocommerce-admin#2732 .
@rrennick rrennick mentioned this issue Aug 1, 2019
Closed
@westonruter westonruter mentioned this issue Aug 2, 2019
Merged
@westonruter
Copy link
Collaborator

@rrennick Can you confirm that #207 fixes the problem for you?

@westonruter westonruter added this to the 0.3 milestone Aug 2, 2019
jeffstieler added a commit to woocommerce/woocommerce-admin that referenced this issue Aug 2, 2019
@jeffstieler
Bail out of our admin_title filter if it's invoked before `current_…
996900b 
…screen`.

See: GoogleChromeLabs/pwa-wp#206
@jeffstieler jeffstieler mentioned this issue Aug 2, 2019
Merged
@rrennick
Copy link
Author

rrennick commented Aug 6, 2019

Can you confirm that #207 fixes the problem for you?

It does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3
Development

Successfully merging a pull request may close this issue.

Ensure $current_screen global is set before applying admin_title filter GoogleChromeLabs/pwa-wp
2 participants
@westonruter @rrennick