Harden workbox-js inclusion and removal of sourceMappingURL comment

GoogleChromeLabs · Jan 28, 2020 · 22605b4 · 22605b4
1 parent 5d226a0
commit 22605b4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/wp-includes/components/class-wp-service-worker-configuration-component.php b/wp-includes/components/class-wp-service-worker-configuration-component.php
@@ -68,8 +68,8 @@ public function get_script() {
 			);
 		} else {
 			// Inline the workbox-sw.js to avoid an additional HTTP request.
-			$script .= file_get_contents( PWA_PLUGIN_DIR . '/' . $workbox_dir . 'workbox-sw.js' ); // phpcs:ignore WordPress.WP.AlternativeFunctions.file_get_contents_file_get_contents
-			$script .= preg_replace( '://# sourceMappingURL=.+?\.map:', '', $script );
+			$wbjs    = file_get_contents( PWA_PLUGIN_DIR . '/' . $workbox_dir . 'workbox-sw.js' ); // phpcs:ignore WordPress.WP.AlternativeFunctions.file_get_contents_file_get_contents
+			$script .= preg_replace( '://# sourceMappingURL=.+?\.map\s*$:s', '', $wbjs );
 		}
 
 		$options = array(