Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project dependencies #112

Merged
merged 36 commits into from
Mar 16, 2020
Merged

Update project dependencies #112

merged 36 commits into from
Mar 16, 2020

Conversation

JuanMaRuiz
Copy link
Contributor

@JuanMaRuiz JuanMaRuiz commented Mar 11, 2020

Project dependencies are outdated and npm shows some warning about the vulnerabilities of the dependencies
psi-vulnerabilities

After update dependencies this is the npm report
fix-npm-vulnerabilities

Not updated dependencies

  • googleapis This update is will arrive with other PR.

  • xo has not been updated because the new default configuration. If dependency is updated to the last version 0.28.0 we get some errors

Screen Shot 2020-03-11 at 20 30 22

If you @exterkamp or @sindresorhus consider that we should update this dependency as well, let me know and I do with the proper lint fixes.

Best regards

JuanMaRuiz and others added 27 commits October 26, 2019 17:11
- Removed call to api.
- Added test to options handler instead
- Merge branch 'feature-optimizing-test' of https://github.com/JuanMaRuiz/psi into feature-optimizing-test
- Removed api-response-test
Co-Authored-By: Shane Exterkamp <[email protected]>
Co-Authored-By: Shane Exterkamp <[email protected]>
* Update index file to use new api
* Update googleapis dependency
@JuanMaRuiz
Copy link
Contributor Author

JuanMaRuiz commented Mar 11, 2020

Update

Now it seems is working.


Hi! Seems the failure is not related with the update

travis-error

I cannot reproduce on local with the same configuration. Any idea @exterkamp ?

Best regards.

@exterkamp
Copy link
Collaborator

Seems the failure is not related with the update

Yeah a failed doc request is the API failing for some reason. Seems flaky, but when I manually re-run these they seem to pass 9/10 times... Might be bad luck.

Changing the test URL to http://example.com/ or Addy's final url of https://addyosmani.com/ might make it less flaky.

@exterkamp exterkamp merged commit 1561b67 into GoogleChromeLabs:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants