Fix issue 115 "Cannot read property 'type' of undefined" (#116)

GoogleChromeLabs · Sep 8, 2020 · 898d7c7 · 898d7c7
1 parent f59a309
commit 898d7c7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/lib/output.js b/lib/output.js
@@ -73,7 +73,7 @@ const opportunities = (lighthouseResult, links) => {
 
   const opportunityRules = rules.filter(rule => {
     const {details} = audits[rule.id];
-    return details.type === 'opportunity' && details.overallSavingsMs > 0;
+    return Boolean(details) && details.type === 'opportunity' && details.overallSavingsMs > 0;
   });
 
   const ret = opportunityRules.map(rule => {

diff --git a/test/fixtures/response.json b/test/fixtures/response.json
@@ -599,13 +599,7 @@
         "description": "Consider adding preconnect or dns-prefetch resource hints to establish early connections to important third-party origins. [Learn more](https://developers.google.com/web/fundamentals/performance/resource-prioritization#preconnect).",
         "score": 1.0,
         "scoreDisplayMode": "numeric",
-        "warnings": [],
-        "details": {
-          "type": "opportunity",
-          "items": [],
-          "overallSavingsMs": 0.0,
-          "headings": []
-        }
+        "warnings": []
       },
       "bootup-time": {
         "id": "bootup-time",