Replace self
with globalThis
for use in Worklets
#617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix runtime errors that occur when Comlink is used in a
Worklet
becauseself
doesn't exist there.I ran into a problem suddenly using Comlink in an
AudioWorklet
getting runtime errors on line 425 because it's looking for the existence of a property on theself
object -- sinceself
isn't available inWorklet
s I just replaced it withglobalThis
and it resolved the issue.(The suddenness of it was just an unrelated tree-shaking issue -- ifI completely misunderstood the timing and presumably need to get some sleep 🙃expose
is optimized out by whatever bundler you're using then theWorklet
never inspectsself
, and never crashes. It's possible that this issue could suddenly affect others if they change how they use Comlink in their projects, even without callingexpose
)