Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(print): throw unsupported operation when content area is empty #992

Merged
merged 3 commits into from
Jul 10, 2023
Merged

feat(print): throw unsupported operation when content area is empty #992

merged 3 commits into from
Jul 10, 2023

Conversation

thiagowfx
Copy link
Contributor

@thiagowfx thiagowfx requested review from OrKoN and jrandolf-2 July 10, 2023 18:10
@thiagowfx thiagowfx changed the title feat(print): trow unsupported operation when content area is empty feat(print): throw unsupported operation when content area is empty Jul 10, 2023
@thiagowfx thiagowfx enabled auto-merge (squash) July 10, 2023 18:11
@thiagowfx
Copy link
Contributor Author

Tested:

tperrotta@tperrotta-macbookpro ~/Projects/chromium-bidi (git)-[thiagowfx/print]
% UPDATE_EXPECTATIONS=false ./runWPTAll.sh webdriver/tests/bidi/browsing_context/print/margin.py

> [email protected] wpt
> wireit webdriver/tests/bidi/browsing_context/print/margin.py

🏃 [tsc] Running command "tsc --build src/tsconfig.json --pretty"
✅ [tsc] Executed successfully
🏃 [rollup] Running command "rollup -c"

lib/cjs/bidiTab/bidiTab.js → lib/iife/mapperTab.js...
created lib/iife/mapperTab.js in 1.6s
✅ [rollup] Executed successfully
🏃 [wpt] Running command "./runWPT.sh"
(./runWPT.sh) Running WPT in headless mode...
(./runWPT.sh) Using chromedriver with mapper...
Running "webdriver/tests/bidi/browsing_context/print/margin.py" with "/Applications/Google Chrome Canary.app/Contents/MacOS/Google Chrome Canary"...
  DEPRECATION: mozlog is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559
Running 1 tests in web-platform-tests

  ▶ Unexpected subtest result in /webdriver/tests/bidi/browsing_context/print/margin.py:
  └ PASS [expected FAIL] test_margin_same_as_page_dimension[top]

  ▶ Unexpected subtest result in /webdriver/tests/bidi/browsing_context/print/margin.py:
  └ PASS [expected FAIL] test_margin_same_as_page_dimension[left]

  ▶ Unexpected subtest result in /webdriver/tests/bidi/browsing_context/print/margin.py:
  └ PASS [expected FAIL] test_margin_same_as_page_dimension[right]

  ▶ Unexpected subtest result in /webdriver/tests/bidi/browsing_context/print/margin.py:
  └ PASS [expected FAIL] test_margin_same_as_page_dimension[bottom]

  ▶ Unexpected subtest result in /webdriver/tests/bidi/browsing_context/print/margin.py:
  └ PASS [expected FAIL] test_margin_same_as_page_dimension[all]

But tests will only pass once web-platform-tests/wpt@ea9d1f6 is merged.

@thiagowfx thiagowfx merged commit 71a8b5c into main Jul 10, 2023
@thiagowfx thiagowfx deleted the thiagowfx/print branch July 10, 2023 18:41
@release-please release-please bot mentioned this pull request Jul 10, 2023
Merged
Lightning00Blade pushed a commit that referenced this pull request Jul 21, 2023
@release-please
chore(main): release chromium-bidi 0.4.18 (#994)
e68cbe8 
🤖 I have created a release *beep* *boop*
---


##
[0.4.18](chromium-bidi-v0.4.17...chromium-bidi-v0.4.18)
(2023-07-21)


### Features

* implement browsingContext.activate
([#1002](#1002))
([22e2417](22e2417))
* implement drag n' drop
([#1006](#1006))
([6443045](6443045))
* **print:** throw unsupported operation when content area is empty
([#992](#992))
([71a8b5c](71a8b5c)),
closes
[#518](#518)
* refactor scripts and realms and fix generator serialization
([#1013](#1013))
([73ea6f0](73ea6f0)),
closes
[#562](#562)
* support iterator serialization
([#1042](#1042))
([9dff121](9dff121))


### Bug Fixes

* don't hold finished requests in memory
([#1058](#1058))
([f15163a](f15163a))
* NavigationStarted Event for sub-frames
([#1009](#1009))
([c4841f8](c4841f8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrKoN OrKoN OrKoN approved these changes

@jrandolf-2 jrandolf-2 Awaiting requested review from jrandolf-2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiagowfx @OrKoN