feat: support user context in permissions #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/user-context-in-permissions
branch
2 times, most recently
from
a5c32ab to
c7aa6ad
Compare
OrKoN
force-pushed
the
orkon/user-context-in-permissions
branch
2 times, most recently
from
3601f57 to
400e98a
Compare
OrKoN
commented
Feb 20, 2024
OrKoN
commented
Feb 20, 2024
|
@sadym-chromium it looks like HTTP server times out in the new test. Do you recall if there was a work-around? |
OrKoN
force-pushed
the
orkon/user-context-in-permissions
branch
2 times, most recently
from
a977bf0 to
7a86b1b
Compare
sadym-chromium
approved these changes
Feb 20, 2024
OrKoN
force-pushed
the
orkon/user-context-in-permissions
branch
from
7a86b1b to
3ef9abe
Compare
|
@sadym-chromium do you have some idea about the http server time outs? it seems to timeout when navigating to the 200 page. |
OrKoN
force-pushed
the
orkon/user-context-in-permissions
branch
2 times, most recently
from
e394bf0 to
2fbee97
Compare
OrKoN
force-pushed
the
orkon/user-context-in-permissions
branch
3 times, most recently
from
70b0c68 to
97297e1
Compare
Right, I believe it's that issue: Fix race condition in local http server in e2e tests. We can skip failing test with the link to the issue. |
OrKoN
force-pushed
the
orkon/user-context-in-permissions
branch
2 times, most recently
from
ad6230c to
1ce0e8a
Compare
OrKoN
force-pushed
the
orkon/user-context-in-permissions
branch
3 times, most recently
from
565f914 to
ef526c9
Compare
OrKoN
force-pushed
the
orkon/user-context-in-permissions
branch
from
ef526c9 to
ba03359
Compare
OrKoN
force-pushed
the
orkon/user-context-in-permissions
branch
from
ba03359 to
6b8d3a9
Compare
OrKoN
pushed a commit
that referenced
this pull request
Feb 22, 2024
🤖 I have created a release *beep* *boop* --- ## [0.5.10](chromium-bidi-v0.5.9...chromium-bidi-v0.5.10) (2024-02-22) ### Features * support user context in permissions ([#1805](#1805)) ([a623dc7](a623dc7)) ### Bug Fixes * limit the mapper tab to 200 lines of logs ([#1846](#1846)) ([9c60d0a](9c60d0a)), closes [#1839](#1839) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
OrKoN
added a commit
that referenced
this pull request
Feb 23, 2024
Raised in #1805 --------- Co-authored-by: Maksim Sadym <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
goog:prefixed user context to allow use cases required by Puppeteer. Once permissions spec issue is resolved w3c/permissions#438 we can remove the prefix.