Fix a Windows path issue in the workbox-cli test. #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauntface
reviewed
Oct 12, 2017
| @@ -10,7 +10,7 @@ describe(`[workbox-cli] app.js`, function() { | |||
| const PROXIED_CONFIG_FILE = path.resolve(process.cwd(), '/will/be/proxied'); | |||
| const PROXIED_ERROR = new Error('proxied error message'); | |||
| const PROXIED_CONFIG = {}; | |||
| const INVALID_CONFIG_FILE = '/does/not/exist'; | |||
| const INVALID_CONFIG_FILE = path.resolve(process.cwd(), '/does/not/exist'); | |||
There was a problem hiding this comment.
Will windows be ok with the forward slashes?
There was a problem hiding this comment.
path.resolve() converts them to whatever the OS uses, so it will be okay with this change in place.
There was a problem hiding this comment.
...at least it should, since I'm doing the same thing earlier, but this PR's AppVeyor run didn't complete due to #883
|
Re-running with #883 merged to confirm that it passes AppVeyor. |
PR-Bot Size PluginChanged File SizesNo file sizes have changed. New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size PluginTotal Size: 8.35KB Gzipped: 3.81KB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton @gauntface
This should fix https://ci.appveyor.com/project/gauntface/sw-helpers/build/1.0.772#L353
Unfortunately, AppVeyor didn't re-run with my latest commits in the PR that introduced the test, so it wasn't picked up prior to merging.