V3 publishing #869
Merged
V3 publishing #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
suggested changes
Oct 10, 2017
package.json
Outdated
| @@ -102,5 +103,7 @@ | |||
| "vinyl-buffer": "^1.0.0", | |||
| "vinyl-source-stream": "^1.1.0" | |||
| }, | |||
| "dependencies": {} | |||
| "dependencies": { | |||
| "gulp-debug": "^3.1.0" | |||
There was a problem hiding this comment.
This looks like it snuck through from testing.
infra/utils/versioning.js
Outdated
| module.exports = (pkgName) => { | ||
| const pkgJson = require(`../../packages/${pkgName}/package.json`); | ||
| const details = ['workbox', pkgName, pkgJson.version]; | ||
| return `function v(){v._version='${details.join(':')}'};v();`; |
There was a problem hiding this comment.
Quick sanity check: are there any concerns about the symbol v ending up clashing with anything else in the same scope? Does v get added in before or after the uglification takes place/
|
@jeffposnick that should be the publishing stuff c'est finis. |
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size PluginTotal Size: 8.32KB Gzipped: 3.79KB |
jeffposnick
approved these changes
Oct 10, 2017
|
It all seems reasonable. Thanks for fighting though this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick @addyosmani @philipwalton