Update the workbox-expiration IDB data model #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
suggested changes
Feb 6, 2019
| // but don't `await` it as we don't want to block the response. | ||
| const updateTimestampDone = cacheExpiration.updateTimestamp(request.url); | ||
| if (event) { | ||
| event.waitUntil(updateTimestampDone); |
There was a problem hiding this comment.
You're going to need to put this in a try/catch, à la https://github.com/GoogleChrome/workbox/pull/1457/files
Samsung Internet 6.4, which I believe we're still trying to support, breaks when you call event.waitUntil() asynchronously: #1435 (comment)
| @@ -155,7 +163,7 @@ class Plugin { | |||
| return true; | |||
| } | |||
|
|
|||
| // If we have a valid headerTime, then our response is fresh iff the | |||
| // If we have a valid headerTime, then our response is fresh if the | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Ahh. I just saw the red underline in my editor and changed it without thinking.
There was a problem hiding this comment.
Good catch. Updated.
philipwalton
commented
Feb 6, 2019
| @@ -155,7 +163,7 @@ class Plugin { | |||
| return true; | |||
| } | |||
|
|
|||
| // If we have a valid headerTime, then our response is fresh iff the | |||
| // If we have a valid headerTime, then our response is fresh if the | |||
There was a problem hiding this comment.
Ahh. I just saw the red underline in my editor and changed it without thinking.
| @@ -155,7 +163,7 @@ class Plugin { | |||
| return true; | |||
| } | |||
|
|
|||
| // If we have a valid headerTime, then our response is fresh iff the | |||
| // If we have a valid headerTime, then our response is fresh if the | |||
There was a problem hiding this comment.
Good catch. Updated.
PR-Bot Size PluginChanged File Sizes
New Files
All File SizesView Table
Workbox Aggregate Size Plugin8.78KB gzip'ed (59% of limit) |
jeffposnick
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick
Fixes #1398, Fixes #1400.
This PR updates the IDB data model used by
workbox-expiration, switching it to from multiple databases (named the same as the cache name), to a single database (namedworkbox-expiration) where the entries in the database have acacheNameproperty.I've also updated how expiration happens to make it more efficient. Previously the entire contents of the object store would be read out, the purgeable entires were determined, and then in a second transaction those entries would be removed. In this PR I've moved the logic that determines what needs to be expired into
CacheTimestampsModel, so it can all happen inside a single transaction.Lastly, I had to update our IDB mocks yet again due to bugs I found when running tests. I've manually confirmed that the logic in this PR does work in Chrome, FF, and Safari's IDB implementations.