Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use stringify-object instead of JSON.stringify #1778

Merged

Conversation

tanhauhau
Copy link
Contributor

Prior to filing a PR, please:

  • open an issue to discuss your proposed change.
  • ensure that gulp lint test passes locally.

R: @jeffposnick @philipwalton

Fixes #1761

  • use stringify-object instead of JSON.stringify

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@tanhauhau
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@jeffposnick
Copy link
Contributor

Thanks a ton for the PR! I'm going to switch the base so that this goes against the next branch, which will be used for the upcoming v4.0.0 release.

@jeffposnick jeffposnick changed the base branch from master to next December 6, 2018 21:26
@jeffposnick jeffposnick force-pushed the tanhauhau/generate-sw-stringify branch from cfd6512 to 40298d4 Compare December 6, 2018 21:55
@jeffposnick jeffposnick self-requested a review December 6, 2018 22:21
Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@jeffposnick jeffposnick merged commit 2b49320 into GoogleChrome:next Dec 6, 2018
@tanhauhau tanhauhau deleted the tanhauhau/generate-sw-stringify branch December 8, 2018 03:59
@tanhauhau
Copy link
Contributor Author

you are welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants