Consistently reject with a WorkboxError when a strategy fails #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwalton
approved these changes
Oct 1, 2018
| @@ -123,7 +127,10 @@ class CacheOnly { | |||
| logger.groupEnd(); | |||
| } | |||
|
|
|||
| return response; | |||
| if (response) { | |||
There was a problem hiding this comment.
Nit: to me it'd make slightly more sense to invert this condition, i.e. throw when there's not a response and default to returning the response. As it is now, it looks like throwing is the default, unconditional behavior (but maybe that's just how I read it).
| @@ -175,7 +179,10 @@ class NetworkFirst { | |||
| logger.groupEnd(); | |||
| } | |||
|
|
|||
| return response; | |||
| if (response) { | |||
There was a problem hiding this comment.
Same comment as above, here and presumably elsewhere.
|
Updated with review feedback. |
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin9.44KB gzip'ed (63% of limit) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
CC: @devnook @sorendam
Fixes #1551, to be merged into the
nextbranch.Previously, some strategies would resolve with
nullinstead of rejecting.There are some updates to the docs that will end up accompanying this (once
v4goes live). For one thing, it makes it easier to provide fallback content viaworkbox.routing.setCatchHandler().