Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Add Total Blocking Time documentation for Lighthouse #1636

Merged
merged 5 commits into from
Oct 11, 2019
Merged

Add Total Blocking Time documentation for Lighthouse #1636

merged 5 commits into from
Oct 11, 2019

Conversation

kaycebasques
Copy link
Contributor

@kaycebasques kaycebasques commented Oct 9, 2019

Fixes #1627

Changes proposed in this pull request:

  • Adds /src/site/content/en/lighthouse-performance/total-blocking-time/index.md

Staged page: https://deploy-preview-1636--web-dev-staging.netlify.com/total-blocking-time/

@googlebot googlebot added the cla: yes Contributor has signed the CLA label Oct 9, 2019
@netlify
Copy link

netlify bot commented Oct 9, 2019

Deploy preview for web-dev-staging ready!

Built with commit eb0dbb7

https://deploy-preview-1636--web-dev-staging.netlify.com

@kaycebasques
Copy link
Contributor Author

kaycebasques commented Oct 9, 2019

Hello @patrickhulce and @deepanjanroy,

I wrote documentation for Total Blocking Time. This will be the page that the Lighthouse report UI links to. Please provide a technical review of the content:

  • Is the explanation of what TBT measures accurate?
  • Is the scoring breakdown accurate?
  • Is the guidance relevant?

Copy link
Contributor

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good to me other than the minor technicality!

@kaycebasques
Copy link
Contributor Author

@patrickhulce thank you for the speedy review, please go through your previous comments and resolve them if you think the updated content addresses your feedback

@patrickhulce
Copy link
Contributor

My resolve comment button seems to be missing on this repo, but everything looks addressed to me!

Copy link

@deepanjanroy deepanjanroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kaycebasques
Copy link
Contributor Author

Thank you @patrickhulce and @deepanjanroy!

@kaycebasques kaycebasques changed the title Add Total Blocking Time content Add Total Blocking Time documentation for Lighthouse Oct 10, 2019
Copy link
Contributor

@robdodson robdodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I guess one thing to think about is how we want to handle all of these URLs when Phil does his metrics section because I imagine he'll also want to talk about Total Blocking Time.

@kaycebasques
Copy link
Contributor Author

kaycebasques commented Oct 11, 2019

@robdodson good point. I renamed it to lighthouse-total-blocking-time. This is the pattern that you and I agreed to use for Largest Contentful Paint. In the long run I'd prefer to have lighthouse/total-blocking-time and use lighthouse/ for all the audit docs. It'll be tricky to redirect the existing Lighthouse docs, like /first-contentful-paint, to Phil's docs now that Lighthouse is linking to web.dev. We could use some other keyword for Phil's docs, e.g. total-blocking-time-guide.

@kaycebasques
Copy link
Contributor Author

I reviewed this with a fresh pair of eyes. Since Rob also reviewed, as well as Patrick (who's usually pretty thorough even though he's only responsible for a technical review) the content should be fine, so I'm going to merge.

@kaycebasques kaycebasques merged commit 844f40b into GoogleChrome:master Oct 11, 2019
@kaycebasques kaycebasques deleted the tbt branch October 11, 2019 20:29
@robdodson
Copy link
Contributor

@robdodson good point. I renamed it to lighthouse-total-blocking-time. This is the pattern that you and I agreed to use for Largest Contentful Paint. In the long run I'd prefer to have lighthouse/total-blocking-time and use lighthouse/ for all the audit docs. It'll be tricky to redirect the existing Lighthouse docs, like /first-contentful-paint, to Phil's docs now that Lighthouse is linking to web.dev. We could use some other keyword for Phil's docs, e.g. total-blocking-time-guide.

Another option would be to have Phil's guides use something like understanding-largest-contentful-paint.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Contributor has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

content: Lighthouse doc for Total Blocking Time
5 participants