-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update React Perf Example #253
Conversation
I've corrected the `lastUpdate` property from `this.props.image` from the incorrect key of `lastUpdated` I've also corrected the use of the `moment` api. Since `this.props.image.lastUpdate` is epoch time, you have to invoke `moment.unix()` on it.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
CLAs look good, thanks! |
CC: @paullewis |
Wondering if this sample needs to exist anymore. It's served it's purpose imo. @addyosmani @PaulKinlan wdyt? |
Sorry @mrblueblue, should've said thank you for the PR first. I'm just debating whether or not this really fits in the repo. |
Did you want to move it elsewhere for future reference? If not, we could probably nix it. |
Just nix it; there's a copy on my GitHub fork (which is what's linked on the post) |
I've corrected the
lastUpdate
property fromthis.props.image
from the incorrect key oflastUpdated
I've also corrected the use of the
moment
api. Sincethis.props.image.lastUpdate
is epoch time, you have to invokemoment.unix()
on it.Lastly, I've updated React to version 0.14.2.