Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React Perf Example #253

Closed
wants to merge 3 commits into from

Conversation

mrblueblue
Copy link

I've corrected the lastUpdate property from this.props.image from the incorrect key of lastUpdated

I've also corrected the use of the moment api. Since this.props.image.lastUpdate is epoch time, you have to invoke moment.unix() on it.

Lastly, I've updated React to version 0.14.2.

I've corrected the `lastUpdate` property from `this.props.image` from the incorrect key of `lastUpdated`

I've also corrected the use of the `moment` api. Since `this.props.image.lastUpdate` is epoch time, you have to invoke `moment.unix()` on it.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mrblueblue
Copy link
Author

I signed it

@googlebot
Copy link

CLAs look good, thanks!

@mrblueblue mrblueblue changed the title correct fromNow variable assignment Update React Perf Example Nov 18, 2015
@jeffposnick
Copy link
Contributor

CC: @paullewis

@paullewis
Copy link
Contributor

Wondering if this sample needs to exist anymore. It's served it's purpose imo. @addyosmani @PaulKinlan wdyt?

@paullewis
Copy link
Contributor

Sorry @mrblueblue, should've said thank you for the PR first. I'm just debating whether or not this really fits in the repo.

@addyosmani
Copy link
Member

Did you want to move it elsewhere for future reference? If not, we could probably nix it.

@paullewis
Copy link
Contributor

Just nix it; there's a copy on my GitHub fork (which is what's linked on the post)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants