Added new filters to web-bluetooth device-info #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 from a code perspective. Unless @g-ortuno has any feedback from the API perspective, feel free to merge. |
|
|
||
| let filterName = document.getElementById('name').value; | ||
| if (filterName) { | ||
| options.filters.push({name: name}); |
There was a problem hiding this comment.
Shouldn't this be:
{name: filterName}
?
|
One small comment. Otherwise lgtm |
beaufortfrancois
force-pushed
the
requestDeviceName
branch
from
1a89c69 to
51a5c8b
Compare
|
@g-ortuno Can you just simply look at me and slap me please in the face? Thank you! |
beaufortfrancois
added a commit
that referenced
this pull request
Nov 9, 2015
Added new filters to web-bluetooth device-info
|
:) does name filtering work now? |
|
It does ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@jeffposnick, @g-ortuno