-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(build): replace rollup with esbuild #15239
Conversation
Smokerider, and all tests here, passing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much LGTM save for the CI failures
entryPoints: ['report/clients/bundle.js'], | ||
outfile: 'dist/report/bundle.umd.js', | ||
bundle: true, | ||
minify: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This had terser before, did it need to be this way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was on purpose, we only use this in google3 and it gets processed there anyhow.
unrelated to this PR, yarn repo was 404ing |
Closes #13906
Below is a before/after for build time and bundle sizes
main
esbuild
The bundle size increase is significant, but temporary. The next PR will remove terser and use esbuild for minification. Since it will have a number of subtle changes to page functions, I split the PR. As a preview: using esbuild minification for devtools bundle, it takes ~3s total and is currently just ~100K bigger (but may be able to bring this down some)