Fixes #1282

lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html

@@ -108,6 +108,7 @@ <h2>Do better web tester page</h2>
     return Date.now();
   }
   helloDate();
+  const d = Date.now(); // FAIL
   eval('Date.now()'); // FAIL
   new Function('Date.now()')() // FAIL
 }

lighthouse-core/audits/dobetterweb/no-console-time.js

@@ -61,10 +61,25 @@ class NoConsoleTimeAudit extends Audit {
       });
     }
 
+    let debugString;
+
     const pageHost = new URL(artifacts.URL.finalUrl).host;
     // Filter usage from other hosts and keep eval'd code.
     const results = artifacts.ConsoleTimeUsage.usage.filter(err => {
-      return err.isEval ? !!err.url : new URL(err.url).host === pageHost;
+      if (err.isEval) {
+        return !!err.url;
+      }
+
+      // If the violation doesn't have a valid url, don't filter it out, but
+      // warn the user that we don't know what the callsite is.
+      try {
+        return new URL(err.url).host === pageHost;
+      } catch (e) {
+        debugString = 'Lighthouse was unable to determine if some API uses ' +
+                      'were made by this page. It\'s possible a Chrome extension' +
+                      'content script or other eval\'d code is calling this API.';
+      }
+      return true;
     }).map(err => {
       return Object.assign({
         label: `line: ${err.line}, col: ${err.col}`
@@ -76,7 +91,8 @@ class NoConsoleTimeAudit extends Audit {
       extendedInfo: {
         formatter: Formatter.SUPPORTED_FORMATS.URLLIST,
         value: results
-      }
+      },
+      debugString
     });
   }
 }

lighthouse-core/audits/dobetterweb/no-datenow.js

@@ -61,17 +61,25 @@ class NoDateNowAudit extends Audit {
       });
     }
 
+    let debugString;
+
     const pageHost = new URL(artifacts.URL.finalUrl).host;
     // Filter usage from other hosts and keep eval'd code.
-    // If there is no .url in the violation, include it in the results because
-    // we cannot determine if it was from the user's page or a third party.
-    // TODO: better extendedInfo for violations with no URL.
-    // https://github.com/GoogleChrome/lighthouse/issues/1263
     const results = artifacts.DateNowUse.usage.filter(err => {
       if (err.isEval) {
         return !!err.url;
       }
-      return err.url ? new URL(err.url).host === pageHost : true;
+
+      // If the violation doesn't have a valid url, don't filter it out, but
+      // warn the user that we don't know what the callsite is.
+      try {
+        return new URL(err.url).host === pageHost;
+      } catch (e) {
+        debugString = 'Lighthouse was unable to determine if some API uses ' +
+                      'were made by this page. It\'s possible a Chrome extension' +
+                      'content script or other eval\'d code is calling this API.';
+      }
+      return true;
     }).map(err => {
       return Object.assign({
         label: `line: ${err.line}, col: ${err.col}`,
@@ -84,7 +92,8 @@ class NoDateNowAudit extends Audit {
       extendedInfo: {
         formatter: Formatter.SUPPORTED_FORMATS.URLLIST,
         value: results
-      }
+      },
+      debugString
     });
   }
 }

lighthouse-core/gather/driver.js

@@ -702,7 +702,8 @@ class Driver {
                 'Driver failure: Expected evaluateAsync results to be an array ' +
                 `but got "${JSON.stringify(result)}" instead.`);
           }
-          return result;
+          // Filter out usage from extension content scripts.
+          return result.filter(item => !item.isExtension);
         });
     };
 
@@ -738,24 +739,36 @@ function captureJSCallUsage(funcRef, set) {
       // First frame is the function we injected (the one that just threw).
       // Second, is the actual callsite of the funcRef we're after.
       const callFrame = structStackTrace[1];
-      let url = callFrame.getFileName();
+      let url = callFrame.getFileName() || callFrame.getEvalOrigin();
       const line = callFrame.getLineNumber();
       const col = callFrame.getColumnNumber();
       const isEval = callFrame.isEval();
+      let isExtension = false;
       const stackTrace = structStackTrace.slice(1).map(callsite => callsite.toString());
 
-      // If we don't have an URL, (e.g. eval'd code), use the last entry in the
-      // stack trace to give some context: eval(<context>):<line>:<col>
+      // If we don't have an URL, (e.g. eval'd code), use the 2nd entry in the
+      // stack trace. First is eval context: eval(<context>):<line>:<col>.
+      // Second is the callsite where eval was called.
       // See https://crbug.com/646849.
-      if (!url) {
+      if (isEval) {
+        url = stackTrace[1];
+      }
+
+      // Chrome extension content scripts can produce an empty .url and
+      // "<anonymous>:line:col" for the first entry in the stack trace.
+      if (stackTrace[0].startsWith('<anonymous>')) {
+        // Note: Although captureFunctionCallSites filters out crx usage,
+        // filling url here provides context. We may want to keep those results
+        // some day.
         url = stackTrace[0];
+        isExtension = true;
       }
 
       // TODO: add back when we want stack traces.
       // Stack traces were removed from the return object in
       // https://github.com/GoogleChrome/lighthouse/issues/957 so callsites
       // would be unique.
-      return {url, args, line, col, isEval}; // return value is e.stack
+      return {url, args, line, col, isEval, isExtension}; // return value is e.stack
     };
     const e = new __nativeError(`__called ${funcRef.name}__`);
     set.add(JSON.stringify(e.stack));

lighthouse-core/test/audits/dobetterweb/no-console-time-test.js

@@ -84,4 +84,20 @@ describe('Page does not use console.time()', () => {
     assert.equal(auditResult.rawValue, false);
     assert.equal(auditResult.extendedInfo.value.length, 3);
   });
+
+  it('includes results when there is no .url', () => {
+    const auditResult = NoConsoleTimeAudit.audit({
+      ConsoleTimeUsage: {
+        usage: [
+          {line: 10, col: 1},
+          {line: 2, col: 22}
+        ]
+      },
+      URL: {finalUrl: URL},
+    });
+
+    assert.equal(auditResult.rawValue, false);
+    assert.equal(auditResult.extendedInfo.value.length, 2);
+    assert.ok(auditResult.debugString, 'includes debugString');
+  });
 });

lighthouse-core/test/audits/dobetterweb/no-datenow-test.js

@@ -113,5 +113,6 @@ describe('Page does not use Date.now()', () => {
 
     assert.equal(auditResult.rawValue, false);
     assert.equal(auditResult.extendedInfo.value.length, 2);
+    assert.ok(auditResult.debugString, 'includes debugString');
   });
 });