Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle Date.now uses with no call site URL - Fixes #1263 #1277

Merged
merged 1 commit into from
Dec 23, 2016
Merged

Conversation

ebidel
Copy link
Contributor

@ebidel ebidel commented Dec 23, 2016

R: all

#1218 didn't fully fix the issue like we hoped. Adding extra protection in the date.now audit so we don't throw errors.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this Eric

@brendankenny brendankenny merged commit 2299f94 into master Dec 23, 2016
@brendankenny brendankenny deleted the dnd branch December 23, 2016 18:45
@brendankenny brendankenny mentioned this pull request Dec 23, 2016
@brendankenny brendankenny changed the title Fixes #1263 handle Date.now uses with no call site URL - Fixes #1263 Dec 23, 2016
andrewrota pushed a commit to andrewrota/lighthouse that referenced this pull request Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants