Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data URI should not be counted as "third party" #9834

Closed
Krinkle opened this issue Oct 14, 2019 · 1 comment
Closed

Data URI should not be counted as "third party" #9834

Krinkle opened this issue Oct 14, 2019 · 1 comment
Assignees
@patrickhulce
Labels
needs-priority pending-close

Comments

@Krinkle
Copy link

Krinkle commented Oct 14, 2019

Provide the steps to reproduce

  1. Run LH on https://timotijhof.net/
  2. Expand the "Keep request count low section" under "Performance".

What is the current behavior?

Data URIs are counted as "Third party" requests.

Lighthouse Network DevTools
Lighthouse report Screenshot of Network DevTools

What is the expected behavior?

For data URIs to not be counted, or to be counted as regular same-origin requests.

Environment Information

  • Lighthouse 5.2.0
  • Google Chrome 77.0.3865.90
  • macOS 10.14

Related issues
@patrickhulce patrickhulce mentioned this issue Oct 14, 2019
Closed
@patrickhulce
Copy link
Collaborator

This was fixed in third-party-web 0.11.0 🎉 https://github.com/patrickhulce/third-party-web/releases/tag/v0.11.0

(and lighthouse 6.0)

Krinkle referenced this issue in patrickhulce/third-party-web Jun 9, 2020
@patrickhulce
fix: handle data URLs gracefully
4171f49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickhulce patrickhulce

Labels
needs-priority pending-close
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@paulirish @Krinkle @patrickhulce @devtools-bot @Beytoven