-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lantern: data uris include server response time #9833
Comments
Ooooo, yikes, yes let's fix that in lighthouse/lighthouse-core/lib/dependency-graph/simulator/tcp-connection.js Lines 112 to 123 in d50ef9e
|
Given #9834 too we should probably do an audit of our network request usage for data URI mistakes and/or add more data URIs to our smokes :) |
I noticed in the simulator that non-network URLs get treated, I believe, as actual network requests that will use a connection, etc.
Clearly there shouldn't be any server response time, though I think a non-zero RTT makes sense.. probably more like 5-10ms ish.
@patrickhulce can you help me think about how we'd fix this? Looking through the lantern code I'm not sure where we'd handle this case.
The text was updated successfully, but these errors were encountered: