Fix download state not being reactive in offline mode. #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #127
The
VideoDownloader
instances take a little time to initialize, i.e. to fetch download status from IDB. After a hard refresh, the downloader instance usually still was in an indeterminate state, which the application incorrectly interpreted as the video not being downloaded locally.I have updated the downloaded implementation to broadcast state changes and then hooked the single video page to listen to those changes. Once the downloader is initialized, the
disabled
class is removed from the wrappingarticle
element in cases when the video is available, i. e. when it's available for offline playback.Screencast to illustrate the fix
web-dev-offline-status-fix.mp4