Add syntax highlighting to code samples #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dero
requested changes
Sep 16, 2021
There was a problem hiding this comment.
@beaufortfrancois This is a great addition, but we need to make sure code highlighting uses a different palette when dark mode is on. (Either by toggling it in app settings or in the OS.)
Adding the highlight colors to the two existing blocks of CSS color variables should do the trick.
|
Oops! I've completely missed dark mode colors. Thanks for catching! |
dero
approved these changes
Sep 17, 2021
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some code syntax highlighting to code samples with the help of the "highlight.js" package. It makes code samples more readable.
Before
After
Fixes #143