Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

[extension-docs] Add manifest key pages: author, automation, CSP, input_component #3837

Merged
merged 33 commits into from
Jan 10, 2023

Conversation

IanStanion-google
Copy link
Contributor

@IanStanion-google IanStanion-google commented Sep 27, 2022

Submission for Author and CSP key information pages

Changes proposed in this pull request:

  • Adds information pages for CSP and Author manifest keys

FYI

Preview pages

Submission for Author and CSP key information pages
@netlify
Copy link

netlify bot commented Sep 27, 2022

Deploy Preview for developer-chrome-com ready!

Name Link
🔨 Latest commit a67477e
🔍 Latest deploy log https://app.netlify.com/sites/developer-chrome-com/deploys/63b4362781cc0a000855d9eb
😎 Deploy Preview https://deploy-preview-3837--developer-chrome-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@IanStanion-google IanStanion-google self-assigned this Oct 3, 2022
@IanStanion-google IanStanion-google added extensions Issues related to extensions documentation. content labels Oct 3, 2022
@IanStanion-google IanStanion-google changed the title manifest key submission [extension-docs] manifest key Author and CSP documentation submission Oct 3, 2022
@jpmedley
Copy link
Contributor

jpmedley commented Nov 2, 2022

@dotproto This is actually pretty small PR. Is there anything I can do to help you move this forward?

@AmySteam AmySteam changed the title [extension-docs] manifest key Author and CSP documentation submission [extension-docs] Add manifest key pages: author, automation, CSP, input_component Nov 4, 2022
Copy link
Contributor

@dotproto dotproto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. Most of my suggestions are polish, but there are some substantive notes in the CSP content.

@jpmedley
Copy link
Contributor

@dotproto, I keep forgetting to ask you something. When you're done with a PR can you please make sure we have a clear signal of that. If you don't want to use GitHub approval, at least put 'LGTM' in the comment thread and reassign to me.

@IanStanion-google
Copy link
Contributor Author

@dotproto Everything should be done here now, let me know if I'm ready to go :)

@dotproto
Copy link
Contributor

@dotproto, I keep forgetting to ask you something. When you're done with a PR can you please make sure we have a clear signal of that. If you don't want to use GitHub approval, at least put 'LGTM' in the comment thread and reassign to me.

I'm happy to assign, this is just a case of me not being great at coming back to a PR after sharing feedback.

@IanStanion-google, if it's not too much trouble, could you re-request a review once you're reading for another pass? I find that super helpful for understanding when I should take another look vs. just continuing to discuss concerns raised in open conversations.

Screen Shot 2022-11-18 at 3 27 42 PM

@IanStanion-google
Copy link
Contributor Author

@dotproto
Implemented your additional fixes! Thank you for the final look-through!

@jpmedley
Copy link
Contributor

jpmedley commented Jan 3, 2023

@dotproto If your review is done, please add a proper LGTM using the GitHub button. I'll do my copy edit after that.

@jpmedley jpmedley merged commit 3611f57 into main Jan 10, 2023
@jpmedley jpmedley deleted the Ian-manifest-keys branch January 10, 2023 21:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
content extensions Issues related to extensions documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants