-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[extension-docs] Add manifest key pages: author, automation, CSP, input_component #3837
Conversation
Submission for Author and CSP key information pages
✅ Deploy Preview for developer-chrome-com ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Adjusted the title headers based on Joe's feedback
@dotproto This is actually pretty small PR. Is there anything I can do to help you move this forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start. Most of my suggestions are polish, but there are some substantive notes in the CSP content.
site/en/docs/extensions/mv3/manifest/content_security_policy/index.md
Outdated
Show resolved
Hide resolved
site/en/docs/extensions/mv3/manifest/content_security_policy/index.md
Outdated
Show resolved
Hide resolved
site/en/docs/extensions/mv3/manifest/content_security_policy/index.md
Outdated
Show resolved
Hide resolved
site/en/docs/extensions/mv3/manifest/content_security_policy/index.md
Outdated
Show resolved
Hide resolved
site/en/docs/extensions/mv3/manifest/content_security_policy/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Simeon Vincent <[email protected]>
…ndex.md Co-authored-by: Simeon Vincent <[email protected]>
…ndex.md Co-authored-by: Simeon Vincent <[email protected]>
…ndex.md Co-authored-by: Simeon Vincent <[email protected]>
…ndex.md Co-authored-by: Simeon Vincent <[email protected]>
…ndex.md Co-authored-by: Simeon Vincent <[email protected]>
…ndex.md Co-authored-by: Simeon Vincent <[email protected]>
…ndex.md Co-authored-by: Simeon Vincent <[email protected]>
…ndex.md Co-authored-by: Simeon Vincent <[email protected]>
@dotproto, I keep forgetting to ask you something. When you're done with a PR can you please make sure we have a clear signal of that. If you don't want to use GitHub approval, at least put 'LGTM' in the comment thread and reassign to me. |
@dotproto Everything should be done here now, let me know if I'm ready to go :) |
I'm happy to assign, this is just a case of me not being great at coming back to a PR after sharing feedback. @IanStanion-google, if it's not too much trouble, could you re-request a review once you're reading for another pass? I find that super helpful for understanding when I should take another look vs. just continuing to discuss concerns raised in open conversations. |
site/en/docs/extensions/mv3/manifest/content_security_policy/index.md
Outdated
Show resolved
Hide resolved
site/en/docs/extensions/mv3/manifest/content_security_policy/index.md
Outdated
Show resolved
Hide resolved
site/en/docs/extensions/mv3/manifest/content_security_policy/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Simeon Vincent <[email protected]>
Co-authored-by: Simeon Vincent <[email protected]>
…ndex.md Co-authored-by: Simeon Vincent <[email protected]>
…ndex.md Co-authored-by: Simeon Vincent <[email protected]>
…ndex.md Co-authored-by: Simeon Vincent <[email protected]>
Co-authored-by: Simeon Vincent <[email protected]>
@dotproto |
site/en/docs/extensions/mv3/manifest/content_security_policy/index.md
Outdated
Show resolved
Hide resolved
site/en/docs/extensions/mv3/manifest/content_security_policy/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Simeon Vincent <[email protected]>
…ndex.md Co-authored-by: Simeon Vincent <[email protected]>
…ndex.md Co-authored-by: Simeon Vincent <[email protected]>
Staging build for commit 786b9fe started at 2023-01-03T14:05:28Z completed after 0.02 minutes. https://pr-3837-static-dot-dcc-staging.uc.r.appspot.com/ The following pages likely changed with this PR:
|
@dotproto If your review is done, please add a proper LGTM using the GitHub button. I'll do my copy edit after that. |
Submission for Author and CSP key information pages
Changes proposed in this pull request:
FYI
Preview pages