Add separate folder for MP songs #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
ah wait, you mean in game, yea sounds like a good idea |
michael-r-elp
added a commit
that referenced
this pull request
Aug 30, 2024
* wip(1.35): initial refactor and cleanup * feat: "required" flag for RequiredMod check * wip(1.35): new extended status fields https://github.com/Goobwabber/MultiplayerCore/wiki/Multiplayer-Status * wip(1.35): updated / consistent custom MUR error messages * wip(1.35): mark statusUrl as nullable in NetworkConfigPatcher * wip(1.35): level loader - don't wait for non-players, quest consistency * wip(1.35): level loader - fix flipped countdown time logic * Setup code to make the requirement UI work again with non-downloaded maps, also setup code to make the right list and main levelbar work with maps from beatmap packets * Fix null list * More fixes and workarounds for problems with song lists * Add additional logging to entitlement check * Fix level load * Fix entitlement not sent * Fix logging transpiler * Temp fix exception when selecting other players suggestion * Fix patch not working properly Patreon release * Fix entitlement spam during level load * Fix node pose sync state and added score sync controls * Fix sync state values being multiplied * Change from Setup to SetupData on LevelBar, BS 1.37 * Change check for requirements in packet * Disable score validation when BeatmapBasicData notesCount is 0 * Cleanup code * Fix MpBeatmapPacket ordering (#51) * Add compat for 1.35, code cleanup * Fix MpNodePoseSyncStatePacket should use VarLong * Code cleanup/optimization * No score validation for custom levels * Add POC UI for per player difficulty and placeholder VCs * Adjust UI, move start/unready button down * Rename packets * Add a RegisterType function to register a type without callback, mostly useful for testing * Working POC UI for ppd/ppm * Add support for 1.37.1 with backwards compat * Fix potential null dereference * Update difficulty selection when selecting suggestion, set alpha on difficulty selection at game start * Debug logging attempt getting id of failed packet * Allow changing difficulty during normal countdown * Fix send MpBeatmapPacket logic for non-local levels * Add Temporay patch for compatiblity between 1.37.1 and 1.37.0 * ForwardCompat use simpler method to patch * Move PerPlayerUI into new class MpPerPlayerUI * Align code and UI xml to better match the Quest port * Tweak show toggles disabled, when not party owner, fix toggles dissappearing with ready/start button, update manifest * Ensure newly joined players receive map selection * Fix missing used function in MpPerPlayerUI * Fix toggles not enabling when becoming lobby host * Fix ScoreSyncState Packet * Don't reference types not available in older game versions * Fallback to beatsaver data when MpBeatmapPacket is missing * Comment unused code, attempt move toggles when partyhost changes (not working) * Use IPA WaitForTask instead of a WaitUntil, remove unused using statements * Cleanup and improve code * Fix blackscreen when map can't be downloaded / download fails * Update NodePoseSTM to use long and avoid unnecessary type casts * Remove todo comment * Make entitlement checker public * Make LevelBar patch version dependand * Use Newtonsoft deserializer * Check status and override before enablind toggles * LevelDownloader install to custom folder when version 1.37.3+ * Use Setup instead of SetupData * Bump up game version * Per player modifiers, disable song speed modifiers * NoLevelSpectator, patch ResultView instead of LevelBar * BeatSaver bm ignore Chroma, MpPerPlayerUI unregister status callback on dispose * MpPlayerData default initialize GameVersion with current gameversion, MpPlayerManager fixed not sending local MpPlayerData * Removed unused UI classes * add separate folder for mp songs (#39) Co-authored-by: Michael R. <[email protected]> * Fix typo * Remove deleted reference * Re-fix ordering from #51 Allow sending beatmap to single player (newly joined) Co-authored-by: rcelyte <[email protected]> * On player connected, check if selected map is valid * Fixes to map selection * Disable sending MpPlayerData again, I forgot that it's sent from the server not the client --------- Co-authored-by: Roy de Jong <[email protected]> Co-authored-by: RedBrumbler <[email protected]> Co-authored-by: cubic <[email protected]> Co-authored-by: rcelyte <[email protected]> Co-authored-by: ehlor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CustomLevels folder gets too littered, a separate folder feels much nicer.