Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise the sixtyfive (not incl m65s) #1

Closed
wants to merge 4 commits into from
Closed

Reorganise the sixtyfive (not incl m65s) #1

wants to merge 4 commits into from

Conversation

itsjxck
Copy link

@itsjxck itsjxck commented Oct 26, 2021

I ended up playing with this and thought I'd open this PR incase you wanted any of the changes.

The m65s wasn't in the m65h branch that I based this off so I haven't touched that
I based a lot of this on your Mode Eighty setup

Address comments on PR 14685
@Gondolindrim
Copy link
Owner

Gondolindrim commented Oct 27, 2021

Hey @itsjxck , GitHub failed to notify me about your PR so I hadn't seen it before and modified the files anyways.

The problem with how the M80 setup was done is that the 80S and 80H PCBs were designed to have the same matrix, hence making it possible to address them in the same firmware with different layout definitions.

But honestly it became a pain to maintain and code because designing to essentially different matrices to share the same pins and then embark all that into the firmware, so I am honestly not doing that anymore. So 65HA and HI don't share the same matrix pins, therefore I much rather just have then in two different firmwares.

I do however love the info.json files and some modifications, so I will be incorporating some changes into qmk#14685 with co-authoring for you. Thank you so much!

@itsjxck
Copy link
Author

itsjxck commented Oct 27, 2021

Glad I could be of some help at least! I ended up doing this because I wanted to play around with the M65HI in the configurator (which needed all kinds of other hacks in the qmk_web_stack to work) so I'm glad it can still be somewhat useful!

@itsjxck
Copy link
Author

itsjxck commented Oct 27, 2021

Closing as outdated

@itsjxck itsjxck closed this Oct 27, 2021
@Gondolindrim
Copy link
Owner

Awesome! Thank you!

Gondolindrim pushed a commit that referenced this pull request Aug 16, 2022
* Userspace: muppetjones (#1)

Add and update lily58 to work with userspace
Add and update kyria keymap to work with userspace
Add and update planck keymap with userspace
Add etchamouse code and docs to userpace
Add userspace
Update mouse encoder for smoother movement.
Encoder + mouse
Added casemodes by andrewjrae

* Rollback lily58 state reader and add missing GPL

* Apply suggestions from code review

Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Joel Challis <[email protected]>

* fix lily58 keymap

* Updates to user and lily for muppetjones.

Updated parameters for etchamouse for smoother mouse movement. Updated lily keymap and userspace to actually work together.

* Update keyboards/lily58/keymaps/muppetjones/config.h

Co-authored-by: Drashna Jaelre <[email protected]>

* Updated keymaps and userspace

* Little more cleanup.

* Update keyboards/lily58/keymaps/muppetjones/rules.mk

Co-authored-by: Ryan <[email protected]>

* Rollback accidental libchibios update

* Apply suggestions from code review

Co-authored-by: Drashna Jaelre <[email protected]>

* Update kyria keymap

* Move kyria keymap to splitkb/kyria

* Update planck keymap

* Remove all changes to keyboards/lily58/lib/layer_state_reader.c

* Update lily58 keymap

* Recommended change

* Update keymap readme

* Update kyria keymap and userspace

* Apply suggestions from code review

Co-authored-by: Drashna Jaelre <[email protected]>

* Renamed users/muppetjones/README.md to lc

* Update keyboards/lily58/keymaps/muppetjones/config.h

Co-authored-by: Drashna Jaelre <[email protected]>

Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants