2.1.67-Release

Bagnon_ItemInfo/Defaults.lua

@@ -167,7 +167,7 @@ local optionDB = {
 local addonName = string.gsub(Addon, "_", " ")
 
 AceConfigRegistry:RegisterOptionsTable(addonName, optionDB)
-AceConfigDialog:SetDefaultSize(addonName, 400, 300)
+AceConfigDialog:SetDefaultSize(addonName, 404, 306)
 
 SLASH_BAGNON_ITEMLEVEL1 = "/bif"
 SlashCmdList["BAGNON_ITEMLEVEL"] = function(msg)

Bagnon_ItemInfo/Modules/Garbage.lua

@@ -27,14 +27,19 @@ local Addon, Private =  ...
 local Module = Bagnon:NewModule("Bagnon_Garbage")
 local cache = {}
 
+-- WoW API
+local SetItemButtonDesaturated = SetItemButtonDesaturated
+
 Private.cache[Module] = cache
 Private.AddUpdater(Module, function(self)
 
-	if (self.hasItem and BagnonItemInfo_DB.enableGarbage and self.info.quality == 0 and not(self.locked or self.info.isLocked)) then
+	local db = BagnonItemInfo_DB
+
+	if (self.hasItem and db.enableGarbage and self.info.quality == 0 and not(self.locked or self.info.isLocked)) then
 
 		local overlay = cache[self]
 
-		if (BagnonItemInfo_DB.garbageOverlay) then
+		if (db.garbageOverlay) then
 			if (not overlay) then
 				overlay = self:CreateTexture()
 				overlay.icon = self.icon or _G[self:GetName().."IconTexture"]
@@ -44,15 +49,15 @@ Private.AddUpdater(Module, function(self)
 				overlay:SetColorTexture(.04, .013333333, .004705882, .6)
 				cache[self] = overlay
 			end
-			overlay:SetAlpha(.35 + .65*BagnonItemInfo_DB.garbageOverlayAlpha)
+			overlay:SetAlpha(.35 + .65*db.garbageOverlayAlpha)
 			overlay:Show()
 		else
 			if (overlay) then
 				overlay:Hide()
 			end
 		end
 
-		if (BagnonItemInfo_DB.garbageDesaturation) then
+		if (db.garbageDesaturation) then
 			SetItemButtonDesaturated(self, true)
 		else
 			SetItemButtonDesaturated(self, (self.locked or self.info.isLocked))
@@ -84,7 +89,6 @@ if (groupMethod) then
 			slot = bag and bag[slot]
 			if (slot) then
 				Private.updatesByModule[Module](slot)
-				--slot:UpdateLocked()
 			end
 		end
 	end

Bagnon_ItemInfo/Modules/ItemBind.lua

@@ -27,11 +27,15 @@ local Addon, Private =  ...
 local Module = Bagnon:NewModule("Bagnon_BoE")
 local cache = {}
 
--- Speed!
+-- Lua API
 local _G = _G
 local ipairs = ipairs
 local string_find = string.find
 
+-- WoW API
+local C_Container, C_TooltipInfo, TooltipUtil = C_Container, C_TooltipInfo, TooltipUtil
+local CreateFrame, GetItemInfo, GetItemQualityColor = CreateFrame, GetItemInfo, GetItemQualityColor
+
 -- Addon cache
 local retail = Private.IsRetail
 local wrath = Private.IsWrath
@@ -76,9 +80,10 @@ end
 Private.cache[Module] = cache
 Private.AddUpdater(Module, function(self)
 
+	local db = BagnonItemInfo_DB
 	local message, color, mult, _
 
-	if (self.hasItem and BagnonItemInfo_DB.enableItemBind) then
+	if (self.hasItem and db.enableItemBind) then
 
 		local quality, bind = self.info.quality, self.info.bind
 		if (not bind) then
@@ -156,9 +161,9 @@ Private.AddUpdater(Module, function(self)
 
 				message = bind == 3 and L["BoU"] or L["BoE"]
 
-				if (BagnonItemInfo_DB.enableRarityColoring) then
-					color = quality and colors[quality]
-					mult = (quality ~= 3 and quality ~= 4) and .7
+				if (db.enableRarityColoring) then
+					color = quality and colors[quality > 0 and quality or 1]
+					mult = (quality ~= 3 and quality ~= 4 and quality ~= 0 and quality ~= 1) and .7
 				end
 			end
 

Bagnon_ItemInfo/Modules/ItemLevel.lua

@@ -31,12 +31,17 @@ local Container = LibStub("C_Everywhere").Container
 
 local cache = {}
 
--- Speed!
+-- Lua API
 local _G = _G
 local ipairs = ipairs
+local string_gsub = string.gsub
 local string_match = string.match
 local tonumber = tonumber
 
+-- WoW API
+local C_TooltipInfo, TooltipUtil = C_TooltipInfo, TooltipUtil
+local CreateFrame, GetItemInfoInstant, GetItemQualityColor = CreateFrame, GetItemInfoInstant, GetItemQualityColor
+
 local retail = Private.IsRetail
 local tooltip = Private.tooltip
 local tooltipName = Private.tooltipName
@@ -46,8 +51,8 @@ local battlepetclass = Enum.ItemClass.Battlepet
 local font_object = NumberFont_Outline_Med or NumberFontNormal
 
 -- Search patterns
-local s_item_level = "^" .. string.gsub(ITEM_LEVEL, "%%d", "(%%d+)")
-local s_num_slots = "^" .. (string.gsub(string.gsub(CONTAINER_SLOTS, "%%([%d%$]-)d", "(%%d+)"), "%%([%d%$]-)s", "%.+"))
+local s_item_level = "^" .. string_gsub(ITEM_LEVEL, "%%d", "(%%d+)")
+local s_num_slots = "^" .. (string_gsub(string_gsub(CONTAINER_SLOTS, "%%([%d%$]-)d", "(%%d+)"), "%%([%d%$]-)s", "%.+"))
 
 -- Custom color cache
 -- Allows us control, gives us speed.
@@ -72,9 +77,10 @@ end
 Private.cache[Module] = cache
 Private.AddUpdater(Module, function(self)
 
+	local db = BagnonItemInfo_DB
 	local message, color, _
 
-	if (self.hasItem and BagnonItemInfo_DB.enableItemLevel) then
+	if (self.hasItem and db.enableItemLevel) then
 
 		-- https://wowpedia.fandom.com/wiki/Enum.InventoryType
 		local class, equip, level, quality = self.info.class, self.info.equip, self.info.level, self.info.quality
@@ -88,7 +94,7 @@ Private.AddUpdater(Module, function(self)
 
 		-- We only want quality coloring on item- and pet levels, not bag slots.
 		if (isgear or ispet) then
-			if (BagnonItemInfo_DB.enableRarityColoring) then
+			if (db.enableRarityColoring) then
 				color = quality and colors[quality]
 			end
 			-- Update the bagnon cache

Bagnon_ItemInfo/Modules/Uncollected.lua

@@ -27,7 +27,7 @@ local Addon, Private =  ...
 local Module = Bagnon:NewModule("Bagnon_Uncollected")
 local cache = {}
 
--- Speed!
+-- Lua API
 local _G = _G
 local string_find = string.find
 

CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [2.1.67-Release] 2023-11-01
+### Changed
+- Some minor performance tweaks. Everything matters!
+- Made the BoE/BoU labels brighter for poor and common quality items.
+
 ## [2.1.66-Release] 2023-10-26
 ### Fixed
 - All item qualities including poor and common will now display the BoE label when appropriate in Retail.