Add input related apis

[m4gr3d]

No description provided.

[BastiaanOlij]

So I recently did something similar with OpenVR where I added an OpenVRHaptic class that allows us to control a haptic vibration based on its action name (We need to start talking about what the action systems mean for the platforms that don't have them but thats another topic for another day).

So I'm okay with the change itself. What I do wonder about seeing how things work here, the original haptic implementation was piggy backing on the joystick API in Godot (I've often wondered if this was a smart choice) and you can thus set the rumble properties directly on the controllers. Is this also implemented in the plugin? Should we? Or should we see this as the main way forward and eventually adding support in the core layer to implement a more cross platform solution?

[NeoSpark314]

I think it is implemented also in the plugin here:

godot_oculus_mobile/plugin/src/main/cpp/ovr_mobile_controller.cpp

Line 43 in 06f382b

void OvrMobileController::update_controller_vibration(ovrMobile *ovr, ControllerState& controller_state) {

but I have never used it so far.

[m4gr3d]

Thanks for the review!

As @NeoSpark314 mentions, that is also supported and implemented in the OvrMobileController class ( I need to make sure to double-check it's working as expected...).

Not having it would make the interface more complex IMO as it would then be the user's task to figure out how to map the Godot controller's rumble to the Oculus touch controller's haptics, possibly leading to inconsistency in implementations.

Since feedback is limited (sounds, visual & controller haptics), this addition is to give the ability to users to provide feedback for arbitrary game logic (e.g: reaching an objective) instead of having haptics be limited to controller related game logic (e.g: colliding with an in-game object).

If we decide to support the action systems, it should be in addition to the existing functionality, and not replacing it since IMO the current controller rumble-haptic binding is the simplest way for users to trigger haptics for controller-related game logic.