Fixing worldscale for controllers #105
Conversation
BastiaanOlij
force-pushed
the
fix_worldscale_controllers
branch
from
d5bca2f to
39a3c01
Compare
|
Just tried it. Position fix seems to work as intended. But the controller scale is probably Inverse. A world scale of 4.0 makes the player 4.0 larger...:
|
|
ups; posted in the wrong issue before; with the inverse scale size is correct; but it breaks the current setup of getting the right controller mesh by having a negative scale for the right controller:
|
| func _check_worldscale(): | ||
| if was_world_scale != world_scale: | ||
| was_world_scale = world_scale | ||
| var inv_world_scale = 1.0 / was_world_scale |
There was a problem hiding this comment.
as posted in the comment section earlier; this does not need to be inverse as the "world scale" seems to make the player larger.
| var inv_world_scale = 1.0 / was_world_scale | ||
| var controller_scale = Vector3(inv_world_scale, inv_world_scale, inv_world_scale) | ||
| $"LeftTouchController/left-controller".scale = controller_scale | ||
| $"RightTouchController/right-controller".scale = controller_scale |
There was a problem hiding this comment.
I believe here we would need a -controller_scale as the right controller is just a mirrored mesh of the left controller in the demo setup
There was a problem hiding this comment.
Hmmm, my gut feeling says that minusing the scale isn't a very nice solution, then again this is a script very specific to this setup so I'll make that change.
|
@BastiaanOlij Any updates on this PR? |
BastiaanOlij
force-pushed
the
fix_worldscale_controllers
branch
from
39a3c01 to
98ff9dd
Compare
Changing scale of controllers based on worldscale and removing the double applying of worldscale to the tracking.
Haven't looked at hand tracking yet and still downloading SDK so I can test (had to reinstall my PC few weeks back, bah)
fixes #103