Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new editor-only log type for dev hints #538

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

Qubus0
Copy link
Collaborator

@Qubus0 Qubus0 commented Feb 1, 2025

small improvement to highlight specific log messages in the editor meant only for developers. these are not logged in the exported project to keep the file clean.

i've also demoted the one mod hook warning to a hint since the only reason for it being a warning was to draw attention to it, which the hint does better. We should never leave a stray warning in the debugger when everything is set up correctly, to avoid error blindness

@Qubus0 Qubus0 added enhancement New feature or request 4.x labels Feb 1, 2025
@Qubus0 Qubus0 self-assigned this Feb 1, 2025
@Qubus0 Qubus0 requested a review from KANAjetzt February 1, 2025 13:21
Copy link
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍 - is the [/color] thing not present on 4.2?

addons/mod_loader/api/log.gd Outdated Show resolved Hide resolved
@Qubus0 Qubus0 added this pull request to the merge queue Feb 3, 2025
Merged via the queue into GodotModding:4.x with commit a0b3872 Feb 3, 2025
1 check passed
@Qubus0 Qubus0 deleted the hint-logs branch February 3, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants