Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homework4 #7

Merged
merged 5 commits into from
Jan 14, 2023
Merged

Homework4 #7

merged 5 commits into from
Jan 14, 2023

Conversation

Gobi-Kumarasamy
Copy link
Owner

Split and Trim strings.

Issued faced in git commit:

git remote -v
git remote add origin https://github.com/Gobi-Kumarasamy/CPP_homeworks.git

warning: adding embedded git repository (https://stackoverflow.com/questions/47008290/git-how-to-make-outer-repository-and-embedded-repository-work-as-common-standal)

You have added a git repository inside another git repository
*The outer git repository will ignore the inner git repository.
*The inner git repository is known as a submodule.
*In the resources directory (the inner directory with a git repo in): delete the .git folder. You will need to enable hidden files to see this in explorer / finder. Then,
git rm --cached -f ./homework_4/no_strings_attached

@github-actions
Copy link

github-actions bot commented Jan 12, 2023

Test results

Homework Name Task Name Test Name Result
Example homework Example task Ls output test
Copy of the example (fill me) Ls output test
Homework 1 Print hello world Build binary
Output is correct
Homework 2 Fortune teller Build binary
Fortune telling checks out for you in spring
Fortune telling checks out for me in autumn
Homework 3 Guessing game Build binary
Guess 1 out of 1 numbers
Guess after some searching
Homework 4 Strings processing library Configure CMake
Build code
Run your tests
Inject and build validation tests
Run your and validation tests
Strings processing binaries Configure CMake
Build code
Split string
Trim string

With ❤️ from Homework Bot 🤖

@github-actions
Copy link

github-actions bot commented Jan 12, 2023

✅ Wiki is available

Check it out at: https://github.com/Gobi-Kumarasamy/CPP_homeworks/wiki

With 💙 from Homework Bot 🤖

1.Makes googletest a submodule
2.Change the homework CI job to the up-to-date one (Use a reusable workflow for homework checks)
3.Shuffle add_subdirectory calls
@Gobi-Kumarasamy Gobi-Kumarasamy merged commit 5f7abef into main Jan 14, 2023
@Gobi-Kumarasamy Gobi-Kumarasamy deleted the homework4 branch January 14, 2023 20:59
@Gobi-Kumarasamy
Copy link
Owner Author

Issues:
cpp-for-yourself/lectures-and-homeworks#46 (comment)

Solutions:

  • Makes googletest a submodule by calling these commands:

cd homework_4/no_strings_attached
rm .gitmodules # Remove the gitmodules that was not supposed to be there
rm -rf external/googletest # Remove the googletest library that was copied into the repo
git add .gitmodules external/googletest # Stage the above changes
git submodule add https://github.com/google/googletest.git external/googletest # Add googletest submodule
git add ../../../.github/ # Stage the change in submodules
git commit -m "Add googletest as a submodule"

  • Change the homework CI job to the up-to-date one

  • Change the order of add_subdirectory calls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant