Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Concurrency exercise solution. #38

Merged
merged 1 commit into from
Mar 28, 2015

Conversation

Ripounet
Copy link
Contributor

The suggested solution, though clear and elegant, has the following flaws :

  • it does not handle correctly trees of having different sizes.
  • it does not distinguish a zero Value from a non-existant node value.

See my examples, before and after :

However I cannot guarantee right now that there are no goroutine leaks and channels leak (when Same has returned but values are still waiting in ch1 and ch2).

mattetti added a commit that referenced this pull request Mar 28, 2015
Fix Concurrency exercise solution.
@mattetti mattetti merged commit 3e09155 into GoBootcamp:master Mar 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants