Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]refactor: code review and improvement #189

Closed
wants to merge 1 commit into from

Conversation

harryandriyan
Copy link
Contributor

Issue

#3

Description

  • Use consistent functional components, some components still use class-based
  • Organize the Redux folder based on component
  • Some code not aligned with defined lint rule: fixed with npm run lint
  • We need to define the relative path to make the import section code clean and easy to manage
    for example importing ../../utils/TokenController we can make it import { someFunc } from @utils/TokenController
  • Avoid importing whole lodash library import _ from 'lodash'
    Alternative, we can import specific method of the lodash library
    import map from 'lodash/map'
  • Deprecated createStore method in redux

Signed-off-by: Harry Andriyan [email protected]

@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2022

[flex_admin_ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.5% 0.5% Duplication

@harryandriyan harryandriyan changed the title [WIP]Refactor: Code Review and Improvement [WIP]refactor: code review and improvement Apr 21, 2022
@moabu moabu deleted the admin-ui-issue-3 branch August 31, 2022 08:41
@moabu moabu added the emergency Moved in without any review label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emergency Moved in without any review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants