433: Added if checks around class definitions. #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid conflicts with other plugins that may include locales.php for their own use. Alternate if syntax used to avoid triggering coding standards review of entire class.
|
The path to locales.php can be changed via https://github.com/GlotPress/GlotPress-WP/blob/2.0.0/gp-settings.php#L4 which means that custom locales.php need to have the class_exists() too. |
|
I considered it but thought it was better inside the class file as if another plugin pulls a copy of it use then we make sure it doesn't break. We could add the calls_exists() to both places but I didn't like the code duplication. |
This makes sure that if a custom locales.php file has been used and doesn't have the required class checks, it won't break things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid conflicts with other plugins that may include locales.php for their own use.
Alternate if syntax used to avoid triggering coding standards review of entire class.
Resolves #413.