Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Plugin Preview to GlotPress #1748

Merged
merged 17 commits into from
Jan 16, 2024
Merged

Add Plugin Preview to GlotPress #1748

merged 17 commits into from
Jan 16, 2024

Conversation

trymebytes
Copy link
Contributor

@trymebytes trymebytes commented Dec 18, 2023

Problem

There's no way to live preview the GlotPress plugin.

Solution

This adds a "Test Preview" button to the GlotPress page in the plugin directory. When the Test Preview is clicked, GlotPress is loaded in a playground allowing it to be previewed right there in the browser.

The blueprint in this PR can be tested with this link: https://playground.wordpress.net/?blueprint-url=https://raw.githubusercontent.com/GlotPress/GlotPress/add-playground-preview/.wordpress-org/blueprints/blueprint.json

@trymebytes trymebytes marked this pull request as draft December 18, 2023 12:09
@akirk akirk added this to the 4.0 milestone Jan 8, 2024
@akirk akirk changed the title Add live preview to GlotPress Add Plugin Preview to GlotPress Jan 11, 2024
@trymebytes trymebytes force-pushed the add-playground-preview branch from 777cdd6 to eebd1cb Compare January 11, 2024 09:15
@akirk akirk marked this pull request as ready for review January 15, 2024 19:32
@akirk
Copy link
Member

akirk commented Jan 15, 2024

@trymebytes Could you please test this newest version? Thanks!

@akirk akirk force-pushed the add-playground-preview branch from f944ff8 to 36a212f Compare January 15, 2024 19:33
@trymebytes trymebytes requested a review from akirk January 16, 2024 06:53
@trymebytes
Copy link
Contributor Author

Tested and works as expected, thank you!

@akirk
Copy link
Member

akirk commented Jan 16, 2024

I've moved the directory to .wordpress-org so that the https://github.com/10up/action-wordpress-plugin-asset-update action will deploy it.

@akirk akirk merged commit 3e0ddb2 into develop Jan 16, 2024
11 checks passed
@akirk akirk deleted the add-playground-preview branch January 16, 2024 07:22
akirk added a commit that referenced this pull request Jan 16, 2024
---------

Co-authored-by: Alex Kirk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants